-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed config file being overriden when it's blocked by another application. #1236
Conversation
Done. |
All speculations about this issue revolve around inability to read existing config file at some point for an unknown reason. When I removed all permissions from config file, |
No but _stat is valid in order to check for file existence in theory. In case it returns -1 it's becouse the file doesn't exist or a parameter is not valid. I wouldn't be surprised if it's another bug in _stat. I could try to force the internal version in LZDoom, i'm using VS 2017 BTW. On the other side ::exits internally uses GetFileAttributesW. |
This is not what I was asking about. I see no point in change that doesn't fix the problem even if assumptions are correct. The latter wasn't proved, but this doesn't matter if the added code are not called anyway. |
The problem is real, what happens when you remove the permissions from the file? I assume the config is still overriden, i will do some testing in that situation then to see if it's a bug in _stat or ::exists work. Well we would need to change the permissions again before exiting of course. |
Well, i've just confirmed that _stat is broken on windows and the internal version works. I see it's still in GZDoom guarded by #ifdef USING_V110_SDK71 and it's _wstat64i32 but now _wstat64 is used instead. |
No description provided.